Vulnerability · Published May 2, 2024 · Assigned by GitHub_M
CVE-2024-32962XML signature verification bypass due improper verification of signature / signature spoofing
Critical 10.0
In plain English
A critical-severity security flaw in xml-crypto from node-saml. Proof-of-concept exploit code is public. The chance it is exploited in the next 30 days is estimated at 0.8% (higher than 58% of all known vulnerabilities). Ready-made attack tooling exists: public proof-of-concept code. Fixed versions are available - upgrade the affected package.
Official description
xml-crypto is an xml digital signature and encryption library for Node.js. In affected versions the default configuration does not check authorization of the signer, it only checks the validity of the signature per section 3.2.2 of the w3 xmldsig-core-20080610 spec. As such, without additional validation steps, the default configuration allows a malicious actor to re-sign an XML document, place the certificate in a `<KeyInfo />` element, and pass `xml-crypto` default validation checks. As a result `xml-crypto` trusts by default any certificate provided via digitally signed XML document's `<KeyInfo />`. `xml-crypto` prefers to use any certificate provided via digitally signed XML document's `<KeyInfo />` even if library was configured to use specific certificate (`publicCert`) for signature verification purposes. An attacker can spoof signature verification by modifying XML document and replacing existing signature with signature generated with malicious private key (created by attacker) and by attaching that private key's certificate to `<KeyInfo />` element. This vulnerability is combination of changes introduced to `4.0.0` on pull request 301 / commit `c2b83f98` and has been addressed in version 6.0.0 with pull request 445 / commit `21201723d`. Users are advised to upgrade. Users unable to upgrade may either check the certificate extracted via `getCertFromKeyInfo` against trusted certificates before accepting the results of the validation or set `xml-crypto's getCertFromKeyInfo` to `() => undefined` forcing `xml-crypto` to use an explicitly configured `publicCert` or `privateKey` for signature verification.
Affected packages & fixed versions
| Ecosystem | Package | Fixed in | Advisory |
|---|---|---|---|
| npm | xml-crypto | 6.0.0 | GHSA-2xp3-57p7-qf4v |
Affected products (as reported)
| Vendor | Product | Versions |
|---|---|---|
| node-saml | xml-crypto | >= 4.0.0, < 6.0.0 |
Weakness: CWE-347 · Vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:N
References
- https://github.com/node-saml/xml-crypto/security/advisories/GHSA-2xp3-57p7-qf4v x_refsource_CONFIRM
- https://github.com/node-saml/xml-crypto/pull/301 x_refsource_MISC
- https://github.com/node-saml/xml-crypto/pull/445 x_refsource_MISC
- https://github.com/node-saml/xml-crypto/commit/21201723d2ca9bc11288f62cf72552b7d659b000 x_refsource_MISC
- https://github.com/node-saml/xml-crypto/commit/c2b83f984049edb68ad1d7c6ad0739ec92af11ca x_refsource_MISC
- https://www.w3.org/TR/2008/REC-xmldsig-core-20080610/#sec-CoreValidation x_refsource_MISC
- https://security.netapp.com/advisory/ntap-20240705-0003/